search

hpyproject / hpy

HPy: a better API for Python
https://hpyproject.org
MIT License
1.02k stars 52 forks source link

Introduce HPyUnicode_FromEncodedObject and HPyUnicode_Substring. #411

Closed fangerer closed 1 year ago

fangerer commented 1 year ago

Also used in the Numpy/HPy port (builds on PR #410). I recommend reviewing commit by commit.

mattip commented 1 year ago

Somehow PR #412 appears together in this PR. Is that on purpose?

It might be nice to add more tests for the cases where the encoding or error are missing or where start < end

fangerer commented 1 year ago

Somehow PR #412 appears together in this PR. Is that on purpose?

Yes, sorry, for the confusion. This is a chain of PRs to make reviewing easier and avoid conflicts. The chains is:

412 -> #411 -> #410 -> master

That was probably not a good idea. I won't do that in future.

It might be nice to add more tests for the cases where the encoding or error are missing or where start < end

Okay, I'll add some more.

fangerer commented 1 year ago

I still see the commits from #412 that was already merged. Strange.

That's fine because I've opened #412 to the source branch of this PR. So, we are now merging both into master.