search

hpyproject / hpy

HPy: a better API for Python
https://hpyproject.org
MIT License
1.02k stars 52 forks source link

Add structseq.c to extra sources. #432

Closed fangerer closed 1 year ago

fangerer commented 1 year ago

This is an important bug fix for HPy 0.9.0rc1 (and I will create rc2 after this is merged).

When I've added the helper functions HPyStructSequence_New/NewType in PR #415 , I obviously forgot to add it to the list of extra sources in hpy.devel. This may result in an undefined symbol error when linking.

It doesn't show up in the tests because we build a static lib containing the helpers and I did add the new source file to there (in setup.py).

In order to avoid such problems in future, I plan to have the list of helper sources just in one place.

mattip commented 1 year ago

LGTM, just trying to understand the hpy-no-static-libs change.