search

hpyproject / hpy

HPy: a better API for Python
https://hpyproject.org
MIT License
1.02k stars 52 forks source link

Make autogen work under Windows+MSVC #440

Closed KubaO closed 7 months ago

KubaO commented 1 year ago
  1. Default encoding on Windows isn't UTF-8. This caused autogen to mangle the documentation files.
  2. Add detection of MSVC so that autogen will work under msvc command line.

This helps when using hpy under MSVC.

KubaO commented 1 year ago

We don't care about Python 2.7 anymore, right?

fangerer commented 1 year ago

We don't care about Python 2.7 anymore, right?

Hi @KubaO, please excuse my very late answer. We don't really care about Python 2.7 in the sense that we don't run or support HPy on Python 2.7. However, we are running tests on PyPy and some of the test files therefore also need to be Python 2.7 compatible. Anyway, @mattip already has a fix (see #444 ).

mattip commented 1 year ago

Just to be clear: #444 fixes the CI startup failure for 2.7, but if you want to use open with encoding, that won't work on 2.7. So if these code paths are hit when running

python2.7 test/check_py27_compat.py

then the 2.7 CI job will still fail, since that is the command it runs.

Running this PR locally, everything here seems fine.

mattip commented 7 months ago

Close/reopen to trigger CI