search

hpyproject / hpy

HPy: a better API for Python
https://hpyproject.org
MIT License
1.02k stars 52 forks source link

Add a GitHub Action to find typos with codespell #466

Closed cclauss closed 2 months ago

cclauss commented 6 months ago

This GitHub Action uses minimal steps to run in ~5 seconds to rapidly look for typos in the codebase using codespell.

Marmalade, I like marmalade...

https://en.wikipedia.org/wiki/Alan%27s_Psychedelic_Breakfast

steve-s commented 6 months ago

I like that the codespell caught real errors. I don't have a strong opinion on ruff, but there was already a declined PR to enable it. Has anything changed since then? Does this PR enable it in some other way than the previous?

cclauss commented 6 months ago

I would say that a ton has changed given the rapid adoption of ruff. It now has more than 700 lint rules, a conservative --fix capability, and a code formatter that is certainly faster than and often preferred over black.

mattip commented 5 months ago

As I commented in the other PR I think we are not in need of ruff right now. I said there:

I think we should reject this PR. The only time code formatting has become a discussion topic is when use of a tool to format code is proposed. This seems to be the flip side of the "code formatters prevent discussions around formatting": to become "code formatters generate unhelpful and long discussions around code formatting".

mattip commented 5 months ago

PRs that contribute to the adoption and development of HPy would be much more helpful.

cclauss commented 5 months ago

Linting with ruff has been removed.