Closed fangerer closed 2 years ago
LGTM. I'm not sure we should advertise the invalid handle callback though. I see it as being there primarily for our own tests and it can't work on PyPy.
Maybe we worth waiting with publishing this until the docs are fixed in https://github.com/hpyproject/hpy/pull/253
Maybe we worth waiting with publishing this until the docs are fixed in hpyproject/hpy#253
@steve-s I think this PR does not have a lot to do with your PR since this blog post is about 0.0.3 and we won't backport your changes to 0.0.3, right?
we won't backport your changes to 0.0.3, right?
Ah yes, it would have to be back-ported. The unfortunate thing is that the docs show wrong examples. If the release blog post gets some traction and brings people over to the documentation website, it would be good to show working examples there, but the blog post itself links to the "latest" tag of the documentation so as long as it's merged to master...
Hmm, right. Okay, I can wait until your PR is merged. I don't mind.
@antocuni I addressed your comments (remove the invalid handle hook advertisement). Please have another look.
As we've been talking in IRC, I prepared a short blog post about the release of 0.0.3. I took the post for 0.0.2 as template. Please tell me if you think something is missing or wrong.