search

hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.
https://www.getmanta.app
GNU Lesser General Public License v3.0
5.28k stars 476 forks source link

Inverted comma #223

Closed marcobischoff closed 6 years ago

marcobischoff commented 6 years ago

222 As there are some countries which uses the inverted comma as thousand separator I've added this to the currency.

hql287 commented 6 years ago

Hah, this is interesting. How do you type the inverted comma on a US keyboard?

marcobischoff commented 6 years ago

You‘re right, the inverted comma is not the right char; instead it is an apostrophe which is used and this should also be available on an US keyboard. I will make ab update on this.

hql287 commented 6 years ago

Yup, it seems that you're using right single quote ’

hql287 commented 6 years ago

Let's resolve #129 first then we can merge this. Please take a look at #224 and let me know if you want to change or add anything to it. Thanks.

hql287 commented 6 years ago

@marcobischoff: Why do you try to solve #220 with this PR? I'm confused. Also, please use styled-component instead of plain CSS.

I think it would be best if you create a clean (new) PR with only the changes necessary to fix #222. Btw, what countries use inverted comma/ apostrophe as the thousand separator, I'm curious?

marcobischoff commented 6 years ago

@hql287 My repo is/was a little bit messed up. I will create a new PR. Switzerland is a country which use this.

hql287 commented 6 years ago

@marcobischoff Thanks! 👍