hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.
https://www.getmanta.app
GNU Lesser General Public License v3.0
5.28k stars 478 forks source link

Apostrophe as selection of thousand #256

Closed marcobischoff closed 6 years ago

marcobischoff commented 6 years ago

Should solve issue #222

Description

Added the selection for apostrophe as separator.

Related Issue

222

Motivation and Context

I need this.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

hql287 commented 6 years ago

@marcobischoff: Thanks for sending the PR, but please make sure you do the following first:

Also, I think it would be best if you can follow the above suggestions and send a new (clean) PR.

Thanks!

marcobischoff commented 6 years ago

Sorry, then I'm off, as I thought I did send a clean PR at least on GitHub Desktop there was only a bunch of files. I appreciate your time working on this. But I'm lost with this GIT thing.

2018-03-07 16:29 GMT+01:00 Hung Q. Le notifications@github.com:

@marcobischoff https://github.com/marcobischoff: Thanks for sending the PR, but please make sure you do the following first:

  • Make sure your branch has the most up-to-date code from the dev branch of this repo. This is a simple change but your PR has 11 commits with more than changed ...30 files (which are too many).
  • Please resolve all conflicts before sending the PR.
  • Please read the CONTRIBUTING guide, I've spent quite a lot of time to write it and I'm sure it will save you a lot of time in the future.

Also, I think it would be best if you can follow the above suggestions and send a new (clean) PR.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hql287/Manta/pull/256#issuecomment-371175687, or mute the thread https://github.com/notifications/unsubscribe-auth/AGKTpXr3e_w3zwvgKvAqlvnM3pqm_bfnks5tb_zogaJpZM4Sgobs .

hql287 commented 6 years ago

@marcobischoff: Yeah Git/GitHub can be confusing sometimes but it wouldn't take long to know your way around. So take your time and don't be discouraged.

I'll get back to your issue later so don't worry.