Simplify auto check for updates - Githubissues

hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.

https://www.getmanta.app

GNU Lesser General Public License v3.0

5.28k stars 478 forks source link

Simplify auto check for updates #262

Closed hql287 closed 6 years ago

hql287 commented 6 years ago

Description

This PR simplified the way Manta handle checking for updates by removing unnecessary settings and automatically check for update on startup.

Related Issue

Issue #261

Motivation and Context

The user won't need to remember whether they should check for update or not (unless they want to) as this would be handled automatically by Manta.
Unnecessary options such as check for updates frequency will be safely removed from the app, UI will be simplified.

How Has This Been Tested?

[x] On startup, Manta did run the checkForUpdate function silently (Using a simple console.log())
[x] If there's new update, showed a dialogue box
[x] If there's no update, did nothing.
[x] If the user check for update explicitly, always show dialogue box.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have included a migration scheme (If type of change is breaking change)