Fixed tax method feature #208

hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.

https://www.getmanta.app

GNU Lesser General Public License v3.0

5.28k stars 478 forks source link

Fixed tax method feature #208 #277

Open stefanomarra opened 6 years ago

stefanomarra commented 6 years ago

Added fixed tax method to provide a predefined value as a tax.

Description

Added fixed tax method as option in the tax method select and updated templates to handle the new method the right way.

Related Issue

The related issue is described here: #208

Motivation and Context

There are some cases where the tax calculation is fixed to a predefined amount.

How Has This Been Tested?

I tested the new feature manually by changed the tax method and added related jest tests.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I have included a migration scheme (If type of change is breaking change)

hql287 commented 6 years ago

Nice work! 👍

However, it's not quite obvious what changing the option from Default to Fixed mean. It's also a little bit confusing because the Amount's field label is Amount (%) which suggest the amount is a percentage.

Maybe we can:

Change the option's label from Fixed to Fixed Amount
Change the field's label from Amount (%) to Fixed Amount or Amount (Fixed). Or maybe even Amount will do just fine?

Amount Not Changed

stefanomarra commented 6 years ago

@hql287 absolutely right. I will fix this

hql287 commented 6 years ago

@stefanomarra: Any update on this?