hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.
https://www.getmanta.app
GNU Lesser General Public License v3.0
5.28k stars 478 forks source link

[WIP] Allow users to create Estimates #288

Closed farfromrefug closed 5 years ago

farfromrefug commented 6 years ago

I needed to create estimates. So i simply added a new status and make the templates print "estimate" instead of "invoice" with this status.

I you are ok with the way i have done it i will add the missing locales.

hql287 commented 6 years ago

@farfromrefug: Thanks for the PR 👍.

I like the idea but I think the implementation is a bit hacky at the moment because statuses are not being used correctly. I think a better approach would be:

In the future, if you need to create a new type of document, eg a receipt, just repeat the above steps. This approach is future-proof.

Btw, for a non-trivial feature like this, maybe next time you should create an issue first. That way we can discuss the implementation detail in advance and possibly will save you a bit of time.

Let me know what you think. In the meantime, I'll see if I can add this feature to the new design

farfromrefug commented 6 years ago

@hql287 ok will look at it. And i did not create an issue just because i did not have time. I needed an estimate so i implemented it ;)

hql287 commented 6 years ago

Ah, ok. Hope it worked out well for you. 👍 Let me know if you still want to finish the PR with this approach. Thanks!

robgha01 commented 5 years ago

This kind of feature is someting i also needed and i were thinking if we could have a seperate section below Invoice called estimates where we can create em like we do with invoice then if it gets a "go" we could convert it to an invoice ? i think its like @hql287 pointed out above.

How i solved it for now is save the pdf file and import it to office word and modify it there however would be awsome to have it all in Manta.

mikkelking commented 5 years ago

@robgha01 This is a really useful feature.. Are you able to do as @hql287 suggests?

Many of my customers want a quote first, and then they raise a purchase order, at which time I convert it to an invoice for payment. I also need a place to put the Purchase Order Number on the page.

farfromrefug commented 5 years ago

@mikkelking sorry no did not have the time. As this repo is not really maintained anymore, i decided to keep my approach. I now maintain my own version in my fork.

hql287 commented 5 years ago

As this repo is not really maintained anymore @farfromrefug: I'm getting back to this now. Still, it's not easy to find time to work on open source and keeping a full-time job. But I would still be happy to review your work if that's possible.