Electron-settings has an updated API. Changed any calls to get, set, has to getSync, setSync, hasSync respectfully because the old calls are now async and the code relies on these calls in a synchronous fashion.
Updated electron and had to update any initialized BrowserWindow instances to support running in a node environment. When we initialize a browser window, we now have to include the following:
duplicate-package-checker-webpack-plugin is no longer maintained, switched to @cerner/duplicate-package-checker-webpack-plugin which is currently being maintained
Updated moment and changed any calls of .lang to the updated .locale
Updated webpack to V5 which has a few changes in their API.
Related Issue
359 #348
Motivation and Context
This is an amazing app and it has helped many of us in our daily lives. A lot of the dependencies used are out of date, some are not maintained anymore (duplicate package checker) and a lot of the API's have changed since this was last updated and I also had to use a much older version of Node to get this running. There's a lot of discussion about how this project is unmaintained and I thought I'd do my part by updating the dependencies and bringing this project up to date. Alas, I hope this will invite people to hop on in and we can all maintain this as a community.
How Has This Been Tested?
No logic has changed but the API of some dependencies (electron-settings, moment) has changed a bit. Existing tests still pass.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I have included a migration scheme (If type of change is breaking change)
Update project dependencies
Description
Electron-settings has an updated API. Changed any calls to
get
,set
,has
togetSync
,setSync
,hasSync
respectfully because the old calls are now async and the code relies on these calls in a synchronous fashion.duplicate-package-checker-webpack-plugin is no longer maintained, switched to @cerner/duplicate-package-checker-webpack-plugin which is currently being maintained
Updated moment and changed any calls of
.lang
to the updated.locale
Updated webpack to V5 which has a few changes in their API.
Related Issue
359 #348
Motivation and Context
This is an amazing app and it has helped many of us in our daily lives. A lot of the dependencies used are out of date, some are not maintained anymore (duplicate package checker) and a lot of the API's have changed since this was last updated and I also had to use a much older version of Node to get this running. There's a lot of discussion about how this project is unmaintained and I thought I'd do my part by updating the dependencies and bringing this project up to date. Alas, I hope this will invite people to hop on in and we can all maintain this as a community.
How Has This Been Tested?
No logic has changed but the API of some dependencies (electron-settings, moment) has changed a bit. Existing tests still pass.
Types of changes
Checklist: