hqucms / weaver-core

Streamlined neural network training.
MIT License
44 stars 54 forks source link

Question about the "wrap" padding mode #13

Open Ang-Li-95 opened 9 months ago

Ang-Li-95 commented 9 months ago

Dear Huilin,

Sorry to bother you and thanks a lot for this handy package!

I have some question about the "wrap" padding mode in the data loader. If I understand correctly, assuming a jagged array as below: array = [ [1,2,3], [4,5] ]

Doing a "wrap" padding to make the array have the shape of (2,6), in which case each row has 6 elements, will give us: array_pad = [ [1,2,3,1,2,3], [4,5,4,5,4,5] ]

In the code, I think the "wrap" padding is performed through this function. And padding the array mentioned above using the _repeat_pad function gives us: array_pad = [ [1,2,3,4,5,1], [4,5,4,5,1,2] ]

I am wondering whether I misunderstood the concept of "wrap" padding or this is a bug in the implementation?

Thank you in advance and I look forward to your reply!

Best regards, Ang