search

hquxmu / ai-contest

Automatically exported from code.google.com/p/ai-contest
0 stars 0 forks source link

typo in visualizer.php #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
you've got 

value="<?php echo $_GET["game_id"]; ?>"/>

in visualizer.php

which should be something more like 

value="<?php echo $_GET['game_id']; ?>"/>

Original issue reported on code.google.com by zeus...@gmail.com on 9 Sep 2010 at 9:10

GoogleCodeExporter commented 9 years ago 
What's the difference between the single and the double quotes?

Original comment by danie...@gmail.com on 20 Sep 2010 at 12:24

GoogleCodeExporter commented 9 years ago 
Perhaps that they are not escaped.  Does this matter given that they are all 
encapsulated within a single quote?  Changing them to a single quote will 
definitely cause an issue, however, due to the already present single quotes.

Original comment by Euphora...@gmail.com on 23 Sep 2010 at 3:14

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
This is a non-issue. The PHP start/end tags take precedence. 

From PHP's perspective, this is what's going on:

echo("value=\"");
echo $_GET['game_id'];
echo("\"/>");

Whether the game_id quotes are single or double has no effect.

Original comment by hage...@gmail.com on 24 Sep 2010 at 1:43

GoogleCodeExporter commented 9 years ago 
Marking invalid based on comments above and that it seems to be working fine.

Original comment by janzert on 24 Oct 2010 at 9:56