search

hrach / navigation-compose-ext

Extensions for Jetpack Navigation Compose: Material 3 BottomSheet, custom ModalSheet, Results and more.
MIT License
24 stars 3 forks source link

AppCompat dependency? #20

Closed fitsuli closed 4 months ago

fitsuli commented 4 months ago

Hi! Thank you for sharing this library. I was looking through your code and stumbled upon the AppCompat dependency on :bottomsheet module that doesn't appear to be used anywhere.

Since the AppCompat itself is relatively heavy, I was wondering is there a reason for you to have it as dependency?

hrach commented 4 months ago

Thanks for pointing out. Yes, it seems we should remove it. Feel free to open PR or I'll fix it later.

fitsuli commented 4 months ago

Thanks for pointing out. Yes, it seems we should remove it. Feel free to open PR or I'll fix it later.

Here's a PR: #21