search

hrach / navigation-compose-ext

Extensions for Jetpack Navigation Compose: Material 3 BottomSheet, custom ModalSheet, Results and more.
MIT License
24 stars 3 forks source link

Added Modifier parameter to BottomSheetHost #33

Closed sebastianmarschall closed 3 months ago

sebastianmarschall commented 3 months ago

Added Modifier to BottomShootHost, as discussed in https://github.com/hrach/navigation-compose-ext/issues/32

hrach commented 3 months ago

Please, could you fix:

[standard:trailing-comma-on-call-site] Missing trailing comma before ")" on two places.

Also, if you want, you may add the same to ModalSheetHost. Thank you.

sebastianmarschall commented 3 months ago

Hi @hrach, fixed it. Regarding ModalSheetHost, there is a Modifier paramter already thats passed into AnimatedContent. I dont know the reason behind this and don't want to break anything.

hrach commented 3 months ago

Thank you 😊