"requestFullscreen" doesn't work in Chrome 71

hrajchert / angular-screenfull

Angular binding to the Screenfull library to allow fullscreen in your app.

http://hrajchert.github.io/angular-screenfull/

MIT License

60 stars 16 forks source link

Closed danielnemetz closed 5 years ago

danielnemetz commented 5 years ago

Having a button with "ngsf-toggle-fullscreen" won't work anymore in Chrome 71 but did work in Chrome 70.

Uncaught (in promise) TypeError: Failed to execute 'requestFullscreen' on 'Element': parameter 1 ('options') is not an object.

Even Examples on project page are broken.

hrajchert commented 5 years ago

I upgraded screenful to 4.0.0, and angular-screenful to 1.0.0 to fix the problem. You should upgrade to 4.0.0 in your setup as well.

Cheers!, thanks for reporting :)

simonberger commented 5 years ago

@hrajchert The 1.0.0 release tag is yet missing.

hrajchert commented 5 years ago

You are right... done it :)