Use sf instead of sp? - Githubissues

hrbrmstr / albersusa

Tools, shapefiles & data to work with an "AlbersUSA" composite projection in R

Other

77 stars 16 forks source link

Use sf instead of sp? #3

Open hadley opened 7 years ago

hadley commented 7 years ago

It's the way of the future!

timelyportfolio commented 7 years ago

This would be very nice. sf made this little example much easier to accomplish. Happy to help if I can. It might be as simple as converting everything and resaving the data files. Or, we could add an argument for class of returned data.

hrbrmstr commented 7 years ago

How about initially along with (these are "live")?

counties_sf: Retreive a U.S. county composite map, optionally with a projection, as a simplefeature
usa_sf: Retreive a U.S. state composite map, optionally with a projection, as a simplefeature

Granted this isn't on CRAN so wiping & loading would be possible. Has a geom_sf() stabilized somewhere?

hadley commented 7 years ago

https://github.com/tidyverse/ggplot2/pull/1990

hrbrmstr commented 7 years ago

lemme add some examples for that to the README and if there is still work to be done in the geom I can try to poke at but it turns out having a full time job and teaching two different college courses is actually a major time eradicator #whoknew?! :-)

On Fri, Jan 27, 2017 at 8:12 AM, Hadley Wickham notifications@github.com wrote:

tidyverse/ggplot2#1990 https://github.com/tidyverse/ggplot2/pull/1990

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hrbrmstr/albersusa/issues/3#issuecomment-275662164, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfHtscHwl2EVBYeDEuN9pxf6P_R11ueks5rWe1FgaJpZM4LuJBZ .

hadley commented 7 years ago

@hrbrmstr sure, no problems. I might also have time to contribute some fixes as I'm using this in a class that I'm co-teaching.

hadley commented 7 years ago

And generally, I'd be tempted to just drop sp support altogether — sf is so much easier, and since this is not on CRAN yet, you're unlikely to break much existing code.