search

hrbrmstr / cdcfluview

:mask: R package to Retrieve U.S. Flu Season Data from the CDC FluView Portal (WHO & ILINet)
https://hrbrmstr.github.io/cdcfluview/index.html
Other
57 stars 21 forks source link

where are the shape files stored? #16

Open nickreich opened 6 years ago

nickreich commented 6 years ago

I've been trying to adapt some of your code for a different project and am trying to figure out how you reference the shapefiles in the cdc_basemap() function. Where are those shapefiles stored or from where are you reading them in?

hrbrmstr commented 6 years ago

The URLs for them are at:

https://github.com/hrbrmstr/cdcfluview/blob/master/R/aaa.R#L17-L22

nickreich commented 6 years ago

Very helpful, thanks! May I suggest making it easier for someone to traceback and find those global variables by either putting them in a more aptly named sourcefile or putting them in the same sourcefile as the cdc_basemap() function? Unless the aaa.R file is some convention I'm not aware of, this seems like a strange place for those links to be hiding. I'd be happy to submit a pull request with this change.

hrbrmstr commented 6 years ago

such a PR is most welcome! I (and some others) tend to use aaa.R as a catch-all for "global" things we want available anywhere without having to use roxygen collate tags. In this case, I totally agree the shapefiles are unlikely to be used outside those functions.

Generally, when I'm doing similar spelunking in other folks' pkgs I tend to try the ::: route when I see something in the sources that aren't populated in the exported namespace. tis sub-optimal, but generally gets to the hidden bits pretty well.