search

hrbrmstr / ggalt

:earth_americas: Extra Coordinate Systems, Geoms, Statistical Transformations & Scales for 'ggplot2'
https://cran.r-project.org/web/packages/ggalt/vignettes/ggalt_examples.html
Other
654 stars 99 forks source link

Reimplementation of the bytes formatter #42

Closed hcraT closed 6 years ago

hcraT commented 6 years ago

I've encountered a problem when ggplot passess in input NAs to the byte formatter. This patch fixes this problem. I've reimplemented the function using logarithms

hrbrmstr commented 6 years ago

Many thanks! This is a great fix + enhancement. Can you also add yourself as a contributor in the DESCRIPTION file (pls)? If you wish to remain more anonymous, just the GH user is fine. - thx

On Tue, Nov 28, 2017 at 9:10 AM, hcraT notifications@github.com wrote:

I've encountered a problem when ggplot passess in input NAs to the byte formatter. This patch fixes this problem. I've reimplemented the function using logarithms

You can view, comment on, or merge this pull request online at:

https://github.com/hrbrmstr/ggalt/pull/42 Commit Summary

  • Reimplementation of the bytes formatter. Adds flexibility and fixes the problem with NAs in the input.
  • Reimplementation of the bytes formatter. Adds flexibility and fixes the problem with NAs in the input.
  • Merge branch 'refactor_bytes' of https://github.com/hcraT/ggalt into refactor_bytes

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hrbrmstr/ggalt/pull/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfHtmkRCij_OMjXHYMh08_iAWguDJF2ks5s7BRsgaJpZM4QtS-g .

hcraT commented 6 years ago

Done.

Thanks!

hrbrmstr commented 6 years ago

Thx! There are minor roxygen doc errors causing the build failure that I can quickly nuke. Merging now.