include point_size param in the mjs_point function

hrbrmstr / metricsgraphics

:chart_with_upwards_trend: htmlwidget interface to the MetricsGraphics.js D3 chart library

Other

132 stars 35 forks source link

Hi! While using this great pkg I noticed that setting the point_size parameter did nothing to change the point sizes. I checked the issues log and one of them was still open about this very thing.

After looking at the code I noticed the simple change hadn't been made yet and was probably forgotten about. So went ahead and did it really quick.

The point_size parameter was simply left out of the function body of the mjs_point() function even though it was defined in the @params section and was listed in the parameters inside the function call. I merely added it into the body.

Now the parameter works as expected and you can probably close out the issue linked above.

hrbrmstr / metricsgraphics

include point_size param in the mjs_point function #43

ty sir. I'm planning a CRAN update in a bit (need to add some things based on how RStudio folks want use it with `flexdashboard`). If you get a sec, can you add your name to the contributors list in `DESCRIPTION`? (I can do it, too, but I just don't want to forget ;-)

hrbrmstr / metricsgraphics

include point_size param in the mjs_point function #43

ty sir. I'm planning a CRAN update in a bit (need to add some things based on how RStudio folks want use it with flexdashboard). If you get a sec, can you add your name to the contributors list in DESCRIPTION? (I can do it, too, but I just don't want to forget ;-)

ty sir. I'm planning a CRAN update in a bit (need to add some things based on how RStudio folks want use it with `flexdashboard`). If you get a sec, can you add your name to the contributors list in `DESCRIPTION`? (I can do it, too, but I just don't want to forget ;-)