search

hrbrmstr / newsflash

Tools to Work with the Internet Archive and GDELT Television Explorer in R
90 stars 9 forks source link

Added explicit call to purrr for map_chr() #12

Closed MikeGruz closed 6 years ago

MikeGruz commented 6 years ago

The call to map_chr() for parameters start_date and end_date doesn't work without the package purrr being imported completely. As per Hadley Wickham's recommendations, I added an explicit call to purrr rather than adding in an importfrom statement in the package import file.

hrbrmstr commented 6 years ago

thx! (i had caught this in a local copy — I'm trying to get v2 of the API to work with the package but the V2 API on GDALT's end has been horribly broken for a while).

If you could also modify the PR and add yourself as a contributor to the DESCRIPTION that'd be a big help and I'll incorporate the PR right away.

MikeGruz commented 6 years ago

Happy to! I've been plinking around with it a bit since noticing the issues with post-2017 dates and will let you know if I figure anything out.

hrbrmstr commented 6 years ago

thx. the main issue now is the way the V2 API handles news source selections. it breaks (you can see it break on the web, too) for "national" as there's something weird going on with the back-end parser. Since there's no pay-for API, they aren't exactly responsive with error reports.