better error messages on query failures

hrbrmstr commented 5 years ago

current error reporting on failed queries — in a word — sucks. must improve.

cgivre commented 5 years ago

Bob, I love your eloquence… You are so correct

On Jan 1, 2019, at 10:23, boB Rudis notifications@github.com wrote:

current error reporting on failed queries — in a word — sucks. must improve.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hrbrmstr/sergeant/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQfvi5N1Xb6qwq_-y2hiLDlG2xvycbYks5u-31qgaJpZM4Zl7vl.

hrbrmstr commented 5 years ago

New ones look like:

library(sergeant)
library(tidyverse)

db <- src_drill("localhost")

tbl(db, "dfs.pcaps")

## # Source:   table<dfs.pcaps> [?? x 4]
## # Database: DrillConnection
## Warning message:
## VALIDATION ERROR: From line 2, column 6 to line 2, column 16: Object 'dfs.pcaps' not found
## 
## Original Query:
## 
##   1: SELECT *
##   2: FROM `dfs.pcaps`
##   3: LIMIT 10
## 
## Query Profile Error Link:
## http://localhost:8047/profiles/832269d4-e3e4-44dd-8df0-01922667284f

So it's easier to find the errant line and also copy/paste the query profile link to do more introspection.

hrbrmstr / sergeant

better error messages on query failures #27