hredestig / pcaMethods

Perform PCA on data with missing values in R
GNU General Public License v2.0
45 stars 10 forks source link

Some minor issues during R check: undefined global functions etc. #21

Open barracuda156 opened 1 year ago

barracuda156 commented 1 year ago
* checking R code for possible problems ... NOTE
BPCA_initmodel: no visible global function definition for ‘cov’
Q2: no visible global function definition for ‘txtProgressBar’
Q2: no visible global function definition for ‘setTxtProgressBar’
Q2: no visible global function definition for ‘cor’
RnipalsPca: no visible global function definition for ‘na.omit’
cvseg : <anonymous>: no visible global function definition for
  ‘na.omit’
llsImpute: no visible global function definition for ‘cor’
nlpca: no visible global function definition for ‘runif’
nlpca: no visible global function definition for ‘rnorm’
plot.pcaRes: no visible global function definition for ‘gray’
plot.pcaRes: no visible global function definition for ‘barplot’
plot.pcaRes: no visible global function definition for ‘legend’
plotPcs : panel: no visible global function definition for ‘abline’
plotPcs : panel: no visible global function definition for ‘lines’
plotPcs : panel: no visible global function definition for ‘points’
plotPcs : panel: no visible global function definition for ‘text’
plotPcs: no visible global function definition for ‘pairs’
ppca: no visible global function definition for ‘rnorm’
ppca: no visible global function definition for ‘cov’
robustSvd: no visible binding for global variable ‘median’
simpleEllipse: no visible global function definition for ‘qf’
svdImpute: no visible global function definition for ‘prcomp’
svdPca: no visible global function definition for ‘prcomp’
plot,pcaRes: no visible global function definition for ‘gray’
plot,pcaRes: no visible global function definition for ‘barplot’
plot,pcaRes: no visible global function definition for ‘legend’
slplot,pcaRes: no visible global function definition for ‘par’
slplot,pcaRes: no visible global function definition for ‘layout’
slplot,pcaRes: no visible global function definition for ‘abline’
slplot,pcaRes: no visible global function definition for ‘lines’
Undefined global functions or variables:
  abline barplot cor cov gray layout legend lines median na.omit pairs
  par points prcomp qf rnorm runif setTxtProgressBar text
  txtProgressBar
Consider adding
  importFrom("grDevices", "gray")
  importFrom("graphics", "abline", "barplot", "layout", "legend",
             "lines", "pairs", "par", "points", "text")
  importFrom("stats", "cor", "cov", "median", "na.omit", "prcomp", "qf",
             "rnorm", "runif")
  importFrom("utils", "setTxtProgressBar", "txtProgressBar")
to your NAMESPACE file.
hredestig commented 1 year ago

Cheers for the issue, I'm happy to consider a merge request since I never seem to find time to work on this project anymore..

barracuda156 commented 1 year ago

Cheers for the issue, I'm happy to consider a merge request since I never seem to find time to work on this project anymore..

@hredestig Thank you, I will see if I can fix that.