search

hrehfeld / QuakeInjector

Download, install and play quake singleplayer maps from the quaddicted.com archive
https://www.quaddicted.com/tools/quake_injector
GNU General Public License v3.0
94 stars 15 forks source link

fix: escape spaces and more in download URLs #144

Closed pettyalex closed 2 years ago

pettyalex commented 2 years ago

Fix the download class to handle URLs that need spaces and other special chars to be escaped.

This should fix https://github.com/hrehfeld/QuakeInjector/issues/143 . I did look at some other alternatives, and the suggestion that was made in that issue seems to be the most robust. Here's some more discussion on the subject: https://stackoverflow.com/questions/4737841/urlencoder-not-able-to-translate-space-character

Thanks for making QuakeInjector, it's a really slick way to find new maps!

SpiritQuaddicted commented 2 years ago

Thanks a lot! This is missing the fix for screenshots but I will try to quickly fix that myself before merging right now.

SpiritQuaddicted commented 2 years ago

Actually, I have no idea how to push commits to this as it is a remote branch. So let me merge it and then put my edits on top... :)

Thanks again for this great contribution!

SpiritQuaddicted commented 2 years ago

Lots of copy and paste because that was fastest, sorry: https://github.com/hrehfeld/QuakeInjector/commit/141271a439149594134ae73ecba8d8bae3dd6848