search

hreinhardt / amqp

Haskell AMQP client library
Other
126 stars 38 forks source link

DNS lookup #6

Closed christianpbrink closed 11 years ago

christianpbrink commented 11 years ago

Not really an issue, just a question.

I'm using your module on Heroku, where my RabbitMQ service is provided by CloudAMQP. Since you require that host be an IP string, I'm doing a DNS lookup on Heroku's CLOUDAMQP_URL environment variable before I call openConnection. Am I overlooking built-in library functionality that should obviate the need for that manual lookup step?

Thanks!

hreinhardt commented 11 years ago

I changed openConnection so that it will resolve hostnames: https://github.com/hreinhardt/amqp/commit/41831999c2ffd5001b451c96572c3f538e614c26 I actually don't remember why I didn't do this before, probably an oversight.

christianpbrink commented 11 years ago

Works. Thank you.