search

hrgdavor / jscadui

MIT License
29 stars 7 forks source link

Balloons appear to be regenerating after toggling dropdown menu on jscad.app #56

Closed hrgdavor closed 2 weeks ago

hrgdavor commented 11 months ago

issue moved from https://github.com/jscad/OpenJSCAD.org/issues/1290

Expected Behavior

When I toggle the show/hide Balloons or Friend parameter menus (hit the triangle dropdown), the balloons should not move or change positions.

Actual Behavior

Instead, they regenerate and change positions. Only hitting rerun or changing an actual parameter should impact their positions.

Steps to Reproduce the Problem

  1. Go to https://jscad.app/ and the balloon example
  2. Hit the triangle dropdown triangle next to the Balloons or Friend parameter menus in the bottom left
  3. Observer the balloons moving

Specifications

Chrome browser.

hrgdavor commented 11 months ago

The issue is that folding parameters groups generates change event ... that is useful for storing state of the form, but we should see how to keep the event and not trigger needless re-run of model. ... maybe move to different event, or mark that it is only change in form shape.

hrgdavor commented 2 weeks ago

fixed on main branch, will be available when next version of jscad.app is live