search

hrimhari / moodle-auth_emailadmin

Moodle plugin to provide email self-registration with admin confirmation
GNU General Public License v3.0
14 stars 20 forks source link

Username {$a->username} url-encoded and dot replaced with %2E in auth_emailadminuserconfirmation #58

Open michaelkoitz opened 1 year ago

michaelkoitz commented 1 year ago

When an admin approves a user signup request and the user receives the email "auth_emailadminuserconfirmation", then the username is url-encoded and the dot is replaced with %2E. https://github.com/hrimhari/moodle-auth_emailadmin/blob/master/classes/message.class.php#L69 That seems to be wrong when the placeholder {$a->username} is not used as part of a URL and is used to include the actual username in that email as information for the user.

In the admin email (with the approval link included) https://github.com/hrimhari/moodle-auth_emailadmin/blob/master/auth.php#L289 where it is used as part of the link, it seems to be more reasonable.

Could you please take a look and advise further?

hrimhari commented 1 year ago

Hello, please create an issue. I'll look into it as soon as I can.

michaelkoitz commented 1 year ago

Hi, sorry what kind of issue and where, do you mean a pull request? I thought this already is an issue ticket.

Thanks, Michael