search

hrimhari / moodle-auth_loginlogoutredir

Login/Logout Static Redirection
GNU General Public License v3.0
8 stars 12 forks source link

use modern constructor for auth_plugin_loginlogoutredir #6

Closed grillonbleu closed 4 years ago

grillonbleu commented 4 years ago

Resolves the following deprecation message:

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; auth_plugin_loginlogoutredir has a deprecated constructor

hrimhari commented 4 years ago

Looks good to me. Could you also bump the 2 last digits on the build version and the last digit of the plugin version pweez?

grillonbleu commented 4 years ago

Sure! Is it OK like this?

grillonbleu commented 4 years ago

Changed accordingly!

hrimhari commented 4 years ago

What Moodle version are you using this plugin for?

grillonbleu commented 4 years ago

I've used this plugin on a few Moodle versions already. The most up to date Moodle I've installed it on is 3.7 (PHP 7.1).

grillonbleu commented 4 years ago

I might install it soon on 3.9 (PHP 7.3) though.