search

hrishikesh-19 / splashgainMoodle

0 stars 0 forks source link

hard coded english language strings #5

Open danmarsden opened 2 years ago

danmarsden commented 2 years ago

eg: https://github.com/hrishikesh-19/splashgainMoodle/blob/main/lmsexport/lib.php#L51

note - all user facing strings must sit in the lang file to allow translation.

this is a blocker for approval in the plugins db.

danmarsden commented 2 years ago

that same file has some naming convention issues: function lmsexport_custom_menu_item does not follow our naming convention rules as per: https://moodledev.io/general/development/policies/codingstyle/frankenstyle (also a blocker for approval)

I also note it has a require_login() call in there - that shouldn't be there in a lib.php style file: https://github.com/hrishikesh-19/splashgainMoodle/blob/main/lmsexport/lib.php#L26-L28

danmarsden commented 2 years ago

... and this function looks incorrect - maybe it could be deleted? https://github.com/hrishikesh-19/splashgainMoodle/blob/main/lmsexport/lib.php#L86