Closed hrishikeshrt closed 2 years ago
There is however an argument for keeping the model map in CDSLDict
because it also serves the purpose of inferring models.
This might be useful in future to ship custom models as part of the package.
Addition of the argument on CDSLCorpus
level definitely makes sense though.
Problem
CDSLDict
has a provision to specify custom models usingmodel_map
, however, theCDSLCorpus
class that manages dictionaries has no provision for it.model_map
fromCDSLDict
and only keep it forCDSLCorpus
while keeping onlylexicon_model
andentry_model
for CDSLDict.Feature Description
CDSLCorpus
) from the perspective of a programmer.model_map
fromCDSLDict
, add it toCDSLCorpus
Reasons
It makes sense from the end-user perspective to never really need to instantiate
CDSLDict
by hand, and letCDSLCorpus
do it, and to that end, it makes sense that arguments required forCDSLDict
are specified through the corpus class.model_map
is basically a map of lexicon and entry models per dictionary. Semantically, one dictionary does not need to be aware of the maps for other dictionaries. The map makes more sense on the corpus-management level.