search

hristo-atanasov / Tasmota-IRHVAC

Home Assistant platform for controlling IR Air Conditioners via Tasmota IRHVAC command and compatible hardware
196 stars 67 forks source link

Consistency fixups #12

Closed RisinT96 closed 3 years ago

RisinT96 commented 4 years ago

Tasmota calls this vendor, so we should stick to that.

hristo-atanasov commented 4 years ago

I hope You realize, that this is "breaking" change. We should keep breaking changes away from users. I'd rather add new variable and give people opportunity to keep their config "as is" for a while, untill it is deprecated. Just like some kind of alias. One thing I hate in HA are these meaningles constant breaking changes - changing variable/constant name. Anyway, soon or later we have to change this. It is leftover from the time when my code wasn't based on Tasmota IRsent/IRreceive (once upon the time, I had my own firmware :D ).

RisinT96 commented 4 years ago

Yeah I am aware of that. Keeping the old parameter as an alias sounds like a good idea, I'll look into it.

Speaking of breaking changes, should probably start creating releases, with the whole semantic versioning stuff, this way people using the current version won't have their systems suddenly break unless they download the new release.

I could help set that up using github actions.

RisinT96 commented 4 years ago

Okay now the users can use either protocol or vendor but not both.

The schema doesn't support making exclusive parameters mandatory, so I had to add a check+log in async_setup_platform, the log should show up on the server logs making it easy to detect if the user forgot to configure it.

hristo-atanasov commented 4 years ago

@RisinT96 Ok. I see there are 3 pull requests. Which of them I should merge? All 3 of them or just this one?

RisinT96 commented 4 years ago

@RisinT96 Ok. I see there are 3 pull requests. Which of them I should merge? All 3 of them or just this one?

Well that depends on you :), if you think that the PRs are of any use, merge them. I tested the code of both of my PRs on my hass instance and they seem to work as expected.