search

hristo-atanasov / Tasmota-IRHVAC

Home Assistant platform for controlling IR Air Conditioners via Tasmota IRHVAC command and compatible hardware
196 stars 67 forks source link

If vendor not on lowercase, state update not working #24

Closed avishayil closed 3 years ago

avishayil commented 3 years ago

I'll fix this in a PR

hristo-atanasov commented 3 years ago

Your PR fixes a problem, that is in common with only one protocol/vendor, but if some of the vendors work only in upper case this will be a problem. If we accept the you PR and if someone needs to use the vendor in uppercase it would not be possible. If we leave it like this everyone can use it as needed.

avishayil commented 3 years ago

Hi @hristo-atanasov in my house I have 2 air conditioners, both vendors were uppercase.

My code only lowercases the vendor name on the Python script that controls HA state, how would that affect the vendors that are working only with uppercase?

hristo-atanasov commented 3 years ago

@avishayil Sorry, you were right! I was wondering how lots of people are vahing this issue, but the code actually works in my case. It seems I have used a custom version version of my custom component. I merged, but now I think your PR may lead to some sending IR issues - usualy Tasmota expects Vendor/Protocol in uppercase. Actually this lowercase check is a bug, made by me by mistake - just one more paste.

hristo-atanasov commented 3 years ago

Ok.. The code is changed! now the vendor should be exactly like everyone see it in Tasmota console. With the same casing. So remember, if you update to fix your vendor casing. This way if Tasmota or IRremoteESP8266 change their requirements I don't have to rewrite the code. And once more - tank you for pointing me the bug. :)