search

hristo-atanasov / Tasmota-IRHVAC

Home Assistant platform for controlling IR Air Conditioners via Tasmota IRHVAC command and compatible hardware
196 stars 67 forks source link

Add support for multiple swing modes #3

Closed joogps closed 3 years ago

joogps commented 4 years ago

This pull request adds support for multiple swing modes (other than "off" and "auto") for climate entities. It allows for both horizontal and vertical swing configuration.

Configuration example

supported_swing_list:
      vertical: # defaults to "off" and "auto"
        - "auto"
        - "lowest"
        - "low"
        - "middle"
        - "high"
        - "highest"
      horizontal: # defaults to an empty list
        - "auto"
        - "leftmax"
        - "left"
        - "middle"
        - "right"
        - "rightmax"

In this case, because vertical and horizontal modes were defined, they will have a prefix added to their names so they become distinguishable (eg "middle" becomes "vertical middle"), since Home Assistant doesn't support two swing mode lists. The integration will then display both mode lists so the user can set each one separately (one at a time).

swing list

The "both" and "off" modes were removed since now there's a more detailed configuration. However, I made another branch that makes the integration automatically create them if both lists have "auto" or "off".

Users that had already defined those parameters will need to reconfigure in order to make the integration finish setup properly.

Updates on IrReceived are also working:

received

hristo-atanasov commented 4 years ago

Is this officially supported bot by Home Assistant Climate Entity and by Tasmota? Remember, that my point is to help hundreds of people at the same time, not playing games with HA or Tasmota software.

hristo-atanasov commented 4 years ago

Is this officially supported bot by Home Assistant Climate Entity and by Tasmota? Remember, that my point is to help hundreds of people at the same time, not playing games with HA or Tasmota software.

Not that I'm concern about HA and their devs .. Not At all. I just don't have where to test it. I have very few ACs, that I can test with, and they don't support such operations. So, if you have tested it on such device can be great, especially if it doesn't conflict with devices, that does't support such extras. :)

joogps commented 4 years ago

It pretty much covers what existed before, the user will only need to do some tweaks. The only thing is that there's just not a both mode anymore, the user needs to set each mode at a time. It's a breaking change, but people updating will (hopefully 😅) read the release notes.

RisinT96 commented 4 years ago

It's definitely supported by Tasmota, as can be seen here: https://tasmota.github.io/docs/Tasmota-IR/#sending-irhvac-commands

I tested the vertical commands manually and they seem to work with my AC (Israeli "Tadiran" which works with the "GREE" vendor).

RisinT96 commented 4 years ago

Seems fine to me 👍

@joogps just fix the merge conflicts and you're golden 😄

hristo-atanasov commented 4 years ago

If everything is working fine, I can merge .. :)

ahmaddxb commented 2 years ago

Did this ever get add i have all those options for my AC