search

hristo-atanasov / Tasmota-IRHVAC

Home Assistant platform for controlling IR Air Conditioners via Tasmota IRHVAC command and compatible hardware
187 stars 64 forks source link

Not working in HA 12.0 update #50

Closed Lauriz7 closed 2 years ago

Lauriz7 commented 2 years ago

Not working anymore, mqtt issues seen in log.

https://pastebin.com/56gh0zWW (log) https://pastebin.com/dxdLBBrw (yaml)

Running Tasmota-ir 10.0

tjhorner commented 2 years ago

Can confirm. Please fix this issue ASAP, I am very cold.

tjhorner commented 2 years ago

It looks like this issue was caused by mqtt.async_publish turning into a coroutine. It needs to be awaited or otherwise dealt with as a coroutine rather than a normal function call.

stibbzy commented 2 years ago

Also confirming I have the same issue since upgrading to 2021.12...

stibbzy commented 2 years ago

I have (at least as far as I can tell) fixed the issue by changing line 1006 of climate.py to self.hass.async_create_task(mqtt.async_publish(self.hass, self.topic, payload))

nao-pon commented 2 years ago

I solved it by making the following changes in my repository.

https://github.com/nao-pon/Tasmota-IRHVAC/commit/f968c9200d087f7237935d2bedf362fb5978a7f6

akdri commented 2 years ago

also work's changing the last line of climate.py mqtt.async_publish(self.hass, self.topic, payload) --> mqtt.publish(self.hass, self.topic, payload)

hristo-atanasov commented 2 years ago

Ok, I see there is a problem .. I'll read the change log .. And I have to update to the newest HA version too .. :)

chicaneau commented 2 years ago

also work's changing the last line of climate.py mqtt.async_publish(self.hass, self.topic, payload) --> mqtt.publish(self.hass, self.topic, payload)

can confirm this works for me too, thanks for the fix. This appears to be the cleanest way to fix the problem

Lauriz7 commented 2 years ago

Ok, I see there is a problem .. I'll read the change log .. And I have to update to the newest HA version too .. :)

Can I also ask you to include fix AC power off in the new version? I think it was relevant for Panasonic/Daikin AC's

kzagatti commented 2 years ago

also work's changing the last line of climate.py mqtt.async_publish(self.hass, self.topic, payload) --> mqtt.publish(self.hass, self.topic, payload)

Confirmed this works here too! Thanks

hristo-atanasov commented 2 years ago

I solved it by making the following changes in my repository.

nao-pon@f968c92

The new version fixes the problem. Thanks to @nao-pon! I want to apologize to everyone experiencing problems because of my slow fixes.

nao-pon commented 2 years ago

I will soon create a PR that may solve some of the issues reported in Issues of this repository. I would like to ask everyone to test.