hristo-atanasov / Tasmota-IRHVAC

Home Assistant platform for controlling IR Air Conditioners via Tasmota IRHVAC command and compatible hardware
196 stars 67 forks source link

HACS compatibility #7

Closed vitorma closed 3 years ago

vitorma commented 4 years ago

Would be nice to have HACS compatibility with this repo.

Captura de tela de 2020-07-29 10-30-32

mrfoxbit commented 4 years ago

Hi,

I still can't add to HACS (v.1.5.2)

image

diogos88 commented 3 years ago

Missing file info.md to be able to add into HACS.

chicaneau commented 3 years ago

I am unable to add via HACS either

hristo-atanasov commented 3 years ago

We're not HACS compatible yet. :)

jcisio commented 3 years ago

New PR https://github.com/hristo-atanasov/Tasmota-IRHVAC/pull/27/files

It's strange, because even without hacs.json, when I clone the repository and add my repository without any change, it works. However, per document, that file is required, so it should be added. The minimum requirement version 0.94 is from the README.

kiwipaulrob commented 3 years ago

Thanks for all your work on this great HA add in (and Merry Christmas!)

I see that you added hacs.json but HACS won't allow me to add your github repository if I use the root url and if use

https://github.com/hristo-atanasov/Tasmota-IRHVAC/

It says - Repostitory structure for v0.110.0 is not compliant

Any thoughts?

chicaneau commented 3 years ago

from doing a little digging, i believe it's not working with HACS due to not having any topics. according to https://hacs.xyz/docs/publish/start you need to have topics, readme (or info.md) and hacs.json with at least a 'name' declared. This repo appears to have all these things except for topics. I could be wrong, but something to try and doesnt require a push

hristo-atanasov commented 3 years ago

What should be the content of this topics file?

chicaneau commented 3 years ago

I don’t think it’s a file. It’s more like tags. See here

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/classifying-your-repository-with-topics

On Wed, 30 Dec 2020 at 9:07 pm, Hristo Atanasov notifications@github.com wrote:

What should be the content of this topics file?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hristo-atanasov/Tasmota-IRHVAC/issues/7#issuecomment-752419038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHK2YJPWRXZQFUGTRAAXYDSXMCXJANCNFSM4PLTHQAQ .

jcisio commented 3 years ago

That was what I had expected too, but I tested and it was not that. E.g. my forked repo (for the previous PR) does not have any topic, and still work https://github.com/jcisio/Tasmota-IRHVAC. My forked repo, completely identical, is compatible but this repo is not. I don't know why :(

jcisio commented 3 years ago

On a second thought, maybe it is because the forked repos are more recent? But you are right, it worth trying to add a topic.

hristo-atanasov commented 3 years ago

Okay, guys, try adding custom repository "https://github.com/hristo-atanasov/Tasmota-IRHVAC/ "to HACS. It should now work. :)

hristo-atanasov commented 3 years ago

I'm not sure what I have to do, to add a logo, so if someone knows - pleace, enlight me! :)

jcisio commented 3 years ago

It looks like that all integration logos are brands, and they are centralized at https://github.com/home-assistant/brands. No fancy custom logo, so maybe it does not matter here.

hristo-atanasov commented 3 years ago

Yes, they are, but the logo is already there (Tasmota logo), but I don't know how to reuse it. I have a permission by Tasmota's screator to use it. But I don't know how to reuse it, without resubmiting it again.

chicaneau commented 3 years ago

Not too sure about the logo. But i can confirm that this component now adds and updates successfully from HACS.

Thankyou so much for doing that :)

hristo-atanasov commented 3 years ago

We are practical guys, so who (except me) cares about the logo .. ;)

hristo-atanasov commented 3 years ago

Well .. Time to close this issue! Happy HACS-ing ;)