search

hristogochev / merkle_hash

Finds the hashes of all files and directories in a directory tree
https://crates.io/crates/merkle_hash
MIT License
16 stars 2 forks source link

Version 3.0.0 Cargo build error out of the box #21

Closed CaptainIsaaca closed 1 year ago

CaptainIsaaca commented 1 year ago

When upgraded the version to 3.0.0 cargo failed to build throwing internal error as follows: --> C:\Users\Name\\.cargo\registry\src\github.com-1ecc6299db9ec823\merkle_hash-3.0.0\src\merkle_node.rs:62:21

62 let Ok(absolute_path) = Utf8PathBuf::from_path_buf(entry?.path())else{ 63 bail!("Path is not valid UTF8 path") 64 }; __^

= note: see issue #87335 https://github.com/rust-lang/rust/issues/87335 for more information

Environment: OS: Windows Rust Version: rustc 1.64.0 (a55dd71d5 2022-09-19) (system) Cargo rust version: rust-version = "1.57"

hristogochev commented 1 year ago

Are you using Rust 1.65.0?

CaptainIsaaca commented 1 year ago

Are you using Rust 1.65.0?

Nope. 1.57 (updated in issue body). Rust version is required by the Tauri framework, bumping it up somehow breaks dependencies.

hristogochev commented 1 year ago

Removed the use of the let-else feature in 741a42. Can you check if it builds for you now using the newest version (3.0.1)?

CaptainIsaaca commented 1 year ago

Yes, magically solved my issue. Even no need to bump the version it fetched the new batch automatically. Thanks for the fix. Great module IMO.