Make GUI compile with Scala 3

hrj / abandon

:relieved: Simple and Robust Accounting

Apache License 2.0

184 stars 26 forks source link

Make GUI compile with Scala 3 #331

Closed b-studios closed 2 years ago

b-studios commented 2 years ago

It looks like the GUI was abandoned (pun intended :) )

Without actually looking into how the GUI is implemented and what it is supposed to do, in this PR I just fixed the compiler bugs until it could be run again.

Since I do not know what the intended behavior is, I cannot actually verify more than that.

I had to drop the externally managed jfxrt.jar file, since it couldn't be found.

hrj commented 2 years ago

Wow, this is amazing. Thanks!

Which version of Java are you trying this with? JavaFX was dropped from the JDK at some point in time, making it difficult to maintain this GUI. But looks like the ScalaFX dependency pulls it back in.

I will merge this tomorrow, after chewing on it a bit. In the long term, I want to move away from JavaFx to a web-based interface, as the latter is much easier to develop. If you are interested in building the webui, please let me know.

b-studios commented 2 years ago

Hey, you're welcome.

Which version of Java are you trying this with?

openjdk version "19" 2022-09-20
OpenJDK Runtime Environment Homebrew (build 19)
OpenJDK 64-Bit Server VM Homebrew (build 19, mixed mode, sharing)

If you are interested in building the webui, please let me know.

Sadly, I won't. I am looking into several Scala codebases of similar size as potential examples in our software engineering lecture :) I hope this would be ok for you?

hrj commented 2 years ago

Sadly, I won't. I am looking into several Scala codebases of similar size as potential examples in our software engineering lecture :) I hope this would be ok for you?

That would be cool! I am sure this code isn't idiomatic Scala. Any tips to improve would be appreciated too, whenever you can share them. In particular, I want to ensure that the core data structures are immutable.