search

hrkfdn / ncspot

Cross-platform ncurses Spotify client written in Rust, inspired by ncmpc and the likes.
BSD 2-Clause "Simplified" License
4.79k stars 206 forks source link

Wrong misalignment/redraws of UI #1427

Open Angry-Maid opened 3 months ago

Angry-Maid commented 3 months ago

Describe the bug Heavily misalignment and wrong redraws of UI.

To Reproduce No idea how to reproduce because it was working fine, a day or two ago, no updates were done to either nushell, or to ncspot. Downgrading doesn't resolve this issue either. The only culprit so far that I can see is the Windows Terminal emu. Terminal was not resized.

Screenshots

https://github.com/hrkfdn/ncspot/assets/24209146/0e4eb8f8-5112-44c2-91a7-33c083e79064

System (please complete the following information):

Angry-Maid commented 3 months ago

I think it may be the issue of new version of Windows Terminal with tab size being inconsistent and rendering in wrong place.

https://github.com/hrkfdn/ncspot/assets/24209146/153de14d-fd33-44c6-92d4-39e66309fd32

Bettehem commented 3 months ago

I don't have a Windows machine to test this on, but this does indeed sound like an issue with Windows and not ncspot

Angry-Maid commented 3 months ago

So testing it out without Windows Terminal emu and just running shells as they are it works fine. Alacritty term emu also works fine. There is still weird caret behavior like in 2nd video when I try out doing same stuff with tabulation in python interactive but I think it's just the problem with locale or something else(which would also be interesting to figure out and fix). Some of the Windows Terminal updated broke caret behavior and it isn't getting reset back.

kand7dev commented 3 months ago

Encountered the same issue today in Windows terminal.

kand7dev commented 2 months ago

Has anyone tried it running on the Preview build of Windows Terminal?

Angry-Maid commented 2 months ago

I did run it on Preview build. Same problem

kand7dev commented 1 month ago

I built ncspot manually inside WSL2. There are no UI issues there. This seems like a Windows-shell issue or some sort.