hrkfdn / ncspot

Cross-platform ncurses Spotify client written in Rust, inspired by ncmpc and the likes.
BSD 2-Clause "Simplified" License
5.07k stars 212 forks source link

Weird symbols in Mac OS #1464

Open ljgonzalez1 opened 5 months ago

ljgonzalez1 commented 5 months ago

Describe the bug In Mac OS some symbols look "broken" if they are not ASCII. Aparently there are some problems displaying some non ASCII characteres, both in its own terminal and over SSH to a linux terminal WITH UTF-8/Unicode support. While running natively on linux it shows fine

To Reproduce You need either an ARM or Intel computer running Mac OS (it happens in both).

A. Through homebrew:

  1. Install ncspot through the homebrew app:

    ```zsh
    brew install ncspot
    ```
  2. Start ncspot and login with your credentials

    ```zsh
    ncspot
    ```

B. Compile ncspot from source

  1. Install rust with the script provided in their website:

    ```zsh
    curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
    ```
  2. Clone the repo (recursively just in case) and go inside the folder:

    ```zsh
    git clone --recursive https://github.com/hrkfdn/ncspot ncspot
    cd ncspot
    ```
  3. Compile de code using cargo and the recommended flags

    ```zsh
    cargo build --no-default-features --features portaudio_backend,pancurses_backend
    ```
  4. Start ncspot and login with your credentials

    ```zsh
    ncspot
    ```

Expected behavior

image

Curent behavior

image

System 1:

System 2:

Additional context

As a suggestion or a question, which files would I need to modify to add ASCII-only support? If I want to create another version of ncspot which replaces all the unicode symbols with unicode + tty-supported characters.

I have the time now, so may be I could learn rust and make a PR with a flag for compiling it that way.

... this doesn't look that bad:

< Search                                                                                         Search: something
       Tracks                                             Albums                        Artists                             Playlists                                Shows               Episodes
Terrence Parker - Somethin' Here - Original Mix                                                          Tribute                                                                             5:11 X
Nirvana - Something In The Way                                                                           Nevermind (Remastered)                                                              3:52 X
The Chainsmokers, Coldplay - Something Just Like This                                                    Memories .... Do Not Open                                                           4:07 X
The Chainsmokers, Coldplay - Something Just Like This                                                    Something Just Like This                                                            4:07 X
Lasgo - Something                                                                                        Some Things                                                                         3:40 X
Two Door Cinema Club - Something Good Can Work                                                           Tourist History                                                                     2:44 X
OneRepublic - Something I Need                                                                           Native                                                                              4:00 X
Muse - Something Human                                                                                   Simulation Theory (Super Deluxe)                                                    3:46 X
The Beatles - Something - Remastered 2009                                                                Abbey Road (Remastered)                                                             3:02 X
Nirvana - Something In The Way - Live                                                                    MTV Unplugged In New York                                                           4:01 |
Phil Collins - Something Happened on the Way to Heaven - 2016 Remaster                                   ...But Seriously (Deluxe Edition)                                                   4:51 |
Robbie Williams, Nicole Kidman - Somethin- Stupid                                                        Swing When You-re Winning                                                           2:50 |
Frank Sinatra, Nancy Sinatra - Somethin- Stupid                                                          The World We Knew                                                                   2:42 |
Zach Bryan - Something in the Orange                                                                     Something in the Orange                                                             3:48 |
Frank Sinatra, Nancy Sinatra - Somethin- Stupid - 2008 Remastered                                        Nothing But The Best (2008 Remastered)                                              2:40 |
Nirvana - Something In The Way - Live                                                                    MTV Unplugged In New York                                                           4:01 |
Lola Marsh - Something Stupid (From -Better Call Saul-)                                                  Something Stupid (From -Better Call Saul-)                                          4:28 |
Simply Red - Something Got Me Started - 2008 Remaster                                                    Stars (Collector-s Edition)                                                         4:00 |
Daft Punk - Something About Us                                                                           Discovery                                                                           3:52 |
Geek Music - Something In The Way (From -The Batman-)                                                    Something In The Way (From -The Batman-)                                            1:59 |
The Beatles - Something - Remastered 2015                                                                1 (Remastered)                                                                      3:01 |
Grace Potter - Something That I Want                                                                     Tangled                                                                             2:43 |
The Beatles - Something - 2019 Mix                                                                       Abbey Road (Super Deluxe Edition)                                                   3:02 |
Eyedress, Dent May - Something About You                                                                 Something About You                                                                 2:33 |
Superorganism - Something For Your M.I.N.D.                                                              Superorganism                                                                       2:45 |
Paul McCartney, Eric Clapton - Something - Live                                                          Concert For George (Live)                                                           4:25 |
Muse - Something Human                                                                                   Simulation Theory (Super Deluxe)                                                    3:46 |
Alphaville - Forever Young                                                                               Forever Young                                                                       3:46 |

=============================================================================----------------------------------------------------------------------------------------------------------------------
 > 31 Minutos - Bailen sin Cesar                                                                                                                                                 0:51 / 1:52 [100%]
rickyelopez commented 4 months ago

Same here, is this a confirmed bug? I'm actually also seeing it on windows.

edit: On Mac I was able to resolve by building locally with cargo build --release --no-default-features --features portaudio_backend,mpris,notify,share_clipboard,crossterm_backend