MPRIS: Restructuring and cleanup

haruInDisguise commented 2 months ago

Describe your changes

My pr addresses some of the inconsistencies in ncspot's mpris implementation. While the previous logic is technically good enough, it is inflexible and reports redundant information. I've tried to address those issues to make it easier for software, that processes mpris events in some way, to accurately react to player updates.

'Metadata' and 'Playback' updates have been separated into their own command
Mpris commands are only emitted from within spotify.rs
Some parts of the application creation logic has been restructured to allow for mpris events to be emitted upon startup
- The initial song loading code has been moved from 'Queue::new' into 'Application::new'.

Issue ticket number and link

This closes #1514

Checklist before requesting a review

[ ] Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
[ ] Changelog was updated with relevant user-facing changes (eg. not dependency updates, not performance improvements, etc.)

Edit: An example of software that requires strict MPRIS compliance would be the MPRIS module for yambar that I am working on.

haruInDisguise commented 2 months ago

I've chosen my naming convention (:p) and also added an exception so clippy does not complain to us about enums starting with the same prefix.

hrkfdn commented 2 months ago

Looks good, let's get it in + sorry for the delay! :)

haruInDisguise commented 2 months ago

No worries! Thanks for taking the time!

hrkfdn / ncspot