Mostly fixes #54. I did not add checks for null values in maps. It's not clear to me that we should forbid this anyway.
Besides that, it turns out we were mostly already throwing NPE for nulls. The only missing ones were the IntTreePMapminus methods.
I also switched to using the built-in requireNonNull method instead of our own bespoke one, and added some additional null checks in all the constructors for good measure.
Dependency note
This PR is built on top of #99, because I wanted to test that PSet.intersect correctly detected nulls. I can rebase this one once that one is merged, if you want.
prdoyle
commented
2 years ago
Mostly fixes #54. I did not add checks for null values in maps. It's not clear to me that we should forbid this anyway.
Besides that, it turns out we were mostly already throwing NPE for nulls. The only missing ones were the
IntTreePMapminusmethods.I also switched to using the built-in
requireNonNullmethod instead of our own bespoke one, and added some additional null checks in all the constructors for good measure.Dependency note
This PR is built on top of #99, because I wanted to test that
PSet.intersectcorrectly detected nulls. I can rebase this one once that one is merged, if you want.