search

hrldcpr / pcollections

A Persistent Java Collections Library
Other
765 stars 79 forks source link

Updated Gradle and added module info #109

Closed BomBardyGamer closed 2 years ago

BomBardyGamer commented 2 years ago

This solves #108 .

I initially tried to avoid having to update Gradle, but nothing really supports Gradle 4 anymore, and I thought it would be worth going to the latest Gradle, as it's the most widely supported, since it's the latest version. I've tested it all, and everything works fine, I even tried the publishing and it seems to publish the module-info properly in the JAR (tested with my own repo), so it works fine.

If you don't want the Gradle update, I can try and come up with a custom solution, however these plugins don't work on Gradle 4 because of a missing feature that is needed to implement the functionality.

hrldcpr commented 2 years ago

Awesome, thank you! I definitely approve of upgrading Gradle.

I fixed an issue with the benchmarking library, but other than that everything seems to work.