search

hrldcpr / pcollections

A Persistent Java Collections Library
Other
765 stars 79 forks source link

Only lower compatibility level for main sources #69

Closed guenhter closed 6 years ago

guenhter commented 6 years ago

Actually I found out a better way: Set the compatibility level of the main sources to 1.6 (you already did that) but leave the rest (tests and benchmark) untouched, so they still can use higher language level features, like lambdas.

It's not needed, to make a new release, because the main sources are already compiled with 1.6. This PR only affects tests and the benchmark.

hrldcpr commented 6 years ago

Thanks, this approach is good to know about!

I think for now we can just leave it as-is, and add this later if we ever want to use newer features in the tests or benchmarks.

(Also until we close #64 we'd need to also make the change in pom.xml, which is annoying…)

guenhter commented 6 years ago

Understood.