Sorted maps and sets (fixes issue #20)

hrldcpr / pcollections

A Persistent Java Collections Library

Other

765 stars 79 forks source link

Sorted maps and sets (fixes issue #20) #92

Closed ran-arigur closed 2 years ago

ran-arigur commented 2 years ago

This pull request addresses issue #20 (SortedSet/TreeSet alternative?), by adding the following:

new interface PSortedMap extending both PMap and java.util.NavigableMap
new interface PSortedSet extending both PSet and java.util.NavigableSet
new classes TreePMap and TreePSet implementing those interfaces (respectively)
a few new classes that support the implementation of TreePMap and TreePSet
corresponding unit-tests and documentation
new methods Empty.sortedMap and Empty.sortedSet

I realize this is kind of huge; if you're on board with the general approach, but want to go back-and-forth with separate pull requests for separate pieces, I'm open to that.

hrldcpr commented 2 years ago

Very cool, thanks! I'll look through this soon, should have some time this week.

ran-arigur commented 2 years ago

Sounds good, thank you!

hrldcpr commented 2 years ago

This is great! I read through most of it and it seems very solid, and the tests are thorough and pass so hopefully it's good! 🤞

I like AbstractUnmodifiableMap and AbstractUnmodifiableSet, we should use them (and similar classes) in the rest of the library.

And making KVTree implement Map.Entry seems like a good idea too, I wonder if IntTree would benefit from a similar trick.

So yeah, I'm gonna go ahead and merge it, YOLO! :shipit:

hrldcpr commented 2 years ago

…just gotta find my old maven credentials, and then I'll do a release, hopefully in the next couple days

ran-arigur commented 2 years ago

Thank you so much!

hrldcpr commented 2 years ago

3.2.0 is live!