hrple / common

MIT License
0 stars 0 forks source link

Issue/3/implement handler functionality for server http #16

Closed brettmostert closed 4 years ago

brettmostert commented 4 years ago

This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will decrease coverage by 5.84%. The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   97.36%   91.52%   -5.85%     
==========================================
  Files           2        2              
  Lines          76      118      +42     
==========================================
+ Hits           74      108      +34     
- Misses          1        7       +6     
- Partials        1        3       +2     
Impacted Files Coverage Δ
server/applicationServer.go 90.00% <81.13%> (-6.78%) :arrow_down:
server/server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c24ed55...3971bd7. Read the comment docs.

brettmostert commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Issues
======
+ Solved 4
- Added 14

Complexity increasing per file
==============================
- server/server_test.go  2
- server/serverHandlerFunc_test.go  3
- server/serverHandler_test.go  3

Clones added
============
- server/applicationServer.go  2
- server/serverHandlerFunc_test.go  17
- server/serverHandler_test.go  14

Clones removed
==============
+ server/server_test.go  -10

See the complete overview on Codacy

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information