hrsh7th / cmp-cmdline

nvim-cmp source for vim's cmdline
MIT License
493 stars 42 forks source link

Numeric completion completes all possibilities when previously it did not #98

Closed fmoda3 closed 1 year ago

fmoda3 commented 1 year ago

Here's how it worked before https://github.com/hrsh7th/cmp-cmdline/commit/d8738f0104a8e2fd71e7e0ecef229423107fa11a:

typing just :150 shows no completions yet:

image

then when you type another character, it starts to complete:

image

but now typing just :150 shows a huge list:

image

while I understand that the large list in the second technically is correct in that its showing every possible completion, I would argue that the previous behavior was more useful. Similarly, if i just type : it doesn't show me everything i can complete with yet, it waits until i have one character to start completing. The way numbers complete now, feels equivalent to just showing me every possible command right off the bat. At least I think having the option to complete using the old behavior should be made available.

fmoda3 commented 1 year ago

@uga-rosa Created a new issue

uga-rosa commented 1 year ago

Ty. Now, I understand the intent to have the state where only :{range} is given and the state where only : is entered be treated similarly. And indeed, I think that is reasonable, so I will create a PR.