hrsh7th / cmp-nvim-lsp-signature-help

cmp-nvim-lsp-signature-help
622 stars 27 forks source link

Highlight current argument in documentation #1

Closed gegoune closed 2 years ago

gegoune commented 2 years ago

Hey, that's very promising, thanks! Do you think it's possible to highlight current argument so it's easier to find it?

hrsh7th commented 2 years ago

This is very difficult to implement perfectly.

BTW, We already highlight the current argument in markdown syntax. https://github.com/hrsh7th/cmp-nvim-lsp-signature-help/blob/main/lua/cmp_nvim_lsp_signature_help/init.lua#L102

gegoune commented 2 years ago

Ah, true, did not notice as it looks very subtle on my colorscheme:

nordic.nvim

Screenshot 2021-12-01 at 08 18 51

tokyonight.nvim

Screenshot 2021-12-01 at 08 20 02

(in both cases middle argument is highlighted)

max397574 commented 2 years ago

Which highlight group is used for this?

hrsh7th commented 2 years ago

This is depending on the markdown syntax. I'm using ` as highlight.

max397574 commented 2 years ago

okay thank you very much

rebelot commented 2 years ago

This is depending on the markdown syntax. I'm using ` as highlight.

I think that uses markdownBold

hrsh7th commented 2 years ago

I've improved the highlight. If your problem would be solved by this, feel free to close this.

https://github.com/hrsh7th/cmp-nvim-lsp-signature-help/commit/3f486a300c7f7296719c0705117afe24e3985766

gegoune commented 2 years ago

It is better now, thank you @hrsh7th!