search

hrsh7th / cmp-nvim-lsp-signature-help

cmp-nvim-lsp-signature-help
622 stars 27 forks source link

Fix activeParameter=-1 for jdtls #29

Closed mikehaertl closed 1 year ago

mikehaertl commented 1 year ago

eclipse.jdt.ls often returns -1 for activeParamer. This seems to be in line with the LSP specs.

Current code only checks if activeParameter lies above the upper limit but not if its below.

Also see https://github.com/eclipse/eclipse.jdt.ls/issues/2434

hrsh7th commented 1 year ago

Thank you for your contribution. I left a small comment. Could you please check it?

hrsh7th commented 1 year ago

LGTM. Thank you!