feat: `config.view.entries.vertical_positioning = 'above'|'below'|'auto'`

hrsh7th / nvim-cmp

A completion plugin for neovim coded in Lua.

MIT License

7.9k stars 394 forks source link

feat: `config.view.entries.vertical_positioning = 'above'|'below'|'auto'` #1701

Open llllvvuu opened 1 year ago

llllvvuu commented 1 year ago

Also applies to docs_view otherwise the docs will cover the text when it is significantly taller than the completion menu.

For Copilot, 'above' works best with vim.opt.scrolloff = 999.

Fixes: #495 Helped-by: Thanatermesis thanatermesis@gmail.com

barnacker commented 12 months ago

Best feature ever, I'm running directly off of your branch now... its perfect.

llllvvuu commented 12 months ago

Thanks! I just fixed it yesterday to fix the docs preview as well

ping @hrsh7th for review

idelice commented 11 months ago

Thanks! I just fixed it yesterday to fix the docs preview as well

ping @hrsh7th for review

Can we even expect any reviews on this? I mean, we still on v0.0.1 with no releases for a long time and no recent activity

lcrownover commented 10 months ago

@hrsh7th What's the deal on this? I'd love to have this merged...

I constantly run into overlapping prompts and if this fixes it, I'd be super happy.

franroa commented 10 months ago

also waiting for this

valenmarton commented 8 months ago

I also cloned your repo, hope it gets merged soon.

smitropoulos commented 7 months ago

@hrsh7th can we please get this reviewed?

Shougo commented 7 months ago

I think it is useful feature. I heard his thoughts before.

But he don't want to add new features now. Because new features increases maintenance cost. He might change his mind though.

He wants to include bug fix only.

lcrownover commented 7 months ago

This is also a bugfix for a very annoying bug that I constantly run into where the completion window covers up the text if your screen isn't large enough.

franroa commented 7 months ago

This is also a bugfix for a very annoying bug that I constantly run into where the completion window covers up the text if your screen isn't large enough.

agree

idelice commented 7 months ago

@hrsh7th are you still maintaining this repo or not?

Shougo commented 6 months ago

It is still maintaining. The responses are slow though. You can see other issues and PRs.

michaelbrusegard commented 4 months ago

I merged this with main from nvim/cmp so it has the latest changes and can be merged, PR is here: https://github.com/llllvvuu/nvim-cmp/pull/1. This was because I wanted multi line ghost text together with the option to put the cmp window above

xzbdmw commented 3 months ago

Forks who are using copilot now can use copilot-cmp with my pr which add multi-line ghost-text and dynamic window flip capability, I has been using it for 2 month, hope there are few bugs https://github.com/hrsh7th/nvim-cmp/pull/1955

oysandvik94 commented 1 month ago

I tested this branch with these settings:

            view = {
                entries = { name = "custom", vertical_positioning = "auto" },
            },

The doc menu is supposed to be placed either above or under, right?

Shougo commented 1 month ago

The issue of document window position is a different matter.

https://github.com/hrsh7th/nvim-cmp/issues/1812

oysandvik94 commented 1 month ago

@Shougo My bad!