hrsh7th / nvim-compe

Auto completion Lua plugin for nvim
MIT License
1.28k stars 54 forks source link

Make the gap between completion menu and floating window removable #169

Closed gbrlsnchs closed 3 years ago

gbrlsnchs commented 3 years ago

When navigating through completion items, there's a secondary floating window showing definitions (at least for LSP items). There's a small gap between the completion menu and that window, and sometimes there's a character from the background buffer in that gap, making it a little harder to read the floating window sometimes.

I imagine it's someone's preference to have it that way, so it would be cool if that gap was removable via configuration.

hrsh7th commented 3 years ago

Feel free to create PR

gbrlsnchs commented 3 years ago

Sure, just wanted to document this issue for later, since I can't work on it right now. That's what issues are for, right? Anyway, I might tackle it later when I get some free time. :wink:

gegoune commented 3 years ago

@hrsh7th if you could point me to where relevant code is I could try top create PR for that as it did bother me today for the first time too.

hrsh7th commented 3 years ago

Thank you. It's implemented in https://github.com/hrsh7th/nvim-compe/blob/master/autoload/compe/documentation.vim .

gegoune commented 3 years ago

Thanks, will have a look over weekend.

hrsh7th commented 3 years ago

I think we should remove gap and provide padding

gegoune commented 3 years ago

Or maybe even add docked window as an option? Some other completion plugin has that.

Didn't have time to look into it @hrsh7th, sorry. Might not have time today either.

hrsh7th commented 3 years ago

Hm... I didn't understand 'docked window' meaning maybe.

I think we should't have a configuration for documentation window appearance.

But I think we should improve documentation appearance.

gegoune commented 3 years ago

Improving it is definitely more important, but what I meant was something like this: https://github.com/ncm2/float-preview.nvim

Could be an option added at some point later.

elianiva commented 3 years ago

removing the gap and adding some padding would be the most ideal solution IMO

hrsh7th commented 3 years ago

I'm tackling it.

hrsh7th commented 3 years ago

@gbrlsnchs I think this problem should be fixed by latest mater now.